Exempt state for MHR Information #1591
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
+ Coverage 72.35% 77.37% +5.01%
==========================================
Files 307 379 +72
Lines 12767 7004 -5763
Branches 2630 1117 -1513
==========================================
- Hits 9237 5419 -3818
+ Misses 3518 1553 -1965
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dimak1
force-pushed
the
feat/exempt-mhr-info
branch
from
3f1b09b to
4303512
Compare
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1591-zmzozvg0.web.app |
|
/gcbrun |
| panelUnitNotes: createPanelUnitNotes(props.unitNotes) | ||
| panelUnitNotes: createPanelUnitNotes(props.unitNotes), | ||
| addUnitNoteDropdown: computed((): UnitNoteDocTypes[] => { | ||
| const dropdown = isRoleStaffReg ? ResidentialExemptionStaffDropDown : ResidentialExemptionQSDropDown |
There was a problem hiding this comment.
@cameron-eyds @doug-lovett for awareness, I'm using this reg staff role (ppr_staff), but across the app we also do use 'staff'.
There was a problem hiding this comment.
Thanks Dima, the API looks at ppr_staff, not staff, when checking endpoint access.
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1591-zmzozvg0.web.app |
dimak1
force-pushed
the
feat/exempt-mhr-info
branch
from
728ce65 to
26c1e4b
Compare
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1591-zmzozvg0.web.app |
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).